Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distributed tracing for Event Hub: do not populate schema in peer.address attribute #7109

Closed
6 tasks
lmolkova opened this issue Jan 25, 2020 · 1 comment · Fixed by #8709
Closed
6 tasks

Distributed tracing for Event Hub: do not populate schema in peer.address attribute #7109

lmolkova opened this issue Jan 25, 2020 · 1 comment · Fixed by #8709
Assignees
@chradek
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Milestone
[2020] June

Comments

@lmolkova
Copy link
Member

  • Package Name: @azure/event-hubs
  • Package Version: 2.1.0
  • Operating system: any
  • nodejs
    • version:
  • browser
    • name/version:
  • typescript
    • version:
  • Is the bug related to documentation in

Describe the bug
Azure SDKs for EventHubs populate peer.adress (EventHub endpoint) inconsistently using different schemas (or no schema).

Example of current behavior:

  • .NET: amqps://azuresdkdemo.servicebus.windows.net
  • JS: sb://azuresdkdemo.servicebus.windows.net
  • Python: azuresdkdemo.servicebus.windows.net
  • Java: azuresdkdemo.servicebus.windows.net

To Reproduce
Steps to reproduce the behavior:

  1. Send message to EventHub with producer client
  2. enable tracing and capture traces using OpenTelemetry (export anywhere: zipkin, jaeger, stdout)

Expected behavior
Assuming schema is an implementation detail and not particularly important for tracing, let's stop populating schema everywhere. I.e. use FQDN instead of endpoint (e.g. azuresdkdemo.servicebus.windows.net)
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Event Hubs labels Jan 25, 2020
@ramya-rao-a ramya-rao-a added this to the [2020] March milestone Jan 25, 2020
@lmolkova lmolkova mentioned this issue Feb 7, 2020
Closed
@chradek chradek modified the milestones: [2020] March, [2020] April Mar 9, 2020
@chradek chradek removed their assignment Mar 9, 2020
@chradek chradek modified the milestones: [2020] April, [2020] May Apr 1, 2020
@ramya-rao-a ramya-rao-a mentioned this issue Apr 8, 2020
Closed
5 tasks
@chradek chradek modified the milestones: [2020] May, [2020] June May 1, 2020
@chradek chradek mentioned this issue May 5, 2020
Merged
@chradek
Copy link
Contributor

chradek commented Jun 8, 2020

This change is now available in @azure/event-hubs version 5.2.1:
https://www.npmjs.com/package/@azure/event-hubs/v/5.2.1

Here's some more info on all the changes that went into this version:
https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/eventhub/event-hubs/CHANGELOG.md#521-2020-06-08

@chradek chradek mentioned this issue Jul 27, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chradek chradek

Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Milestone
[2020] June
Development

Successfully merging a pull request may close this issue.

[event-hubs] send span peer.address maps to fully qualified namespace chradek/azure-sdk-for-js
3 participants
@lmolkova @ramya-rao-a @chradek