Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the reporter options to the rush-yaml-scripts from individual package.jsons #7934

Closed
HarshaNalluru opened this issue Mar 21, 2020 · 3 comments
Assignees
Labels
EngSys This issue is impacting the engineering system.

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Mar 21, 2020

Context - #7931 (comment)

  • The --reporter options are exactly same for all the SDKs.
  • For local runs - we only need spec reporter and not junit-reporter.
  • spec reporter is the default reporter when we don't specify a reporter.
  • Both junit-reporter and spec reporter are required in the CI.

One proposal is to move the reporter options to the rush-yaml scripts where we trigger the test scripts instead of package.jsons if possible.
@KarishmaGhiya is checking if rush and our configs allow this.

@KarishmaGhiya
Copy link
Contributor

KarishmaGhiya commented Mar 25, 2020

Rush doesn't have support for passing additional arguments from the command line yet. But they have an issue for requesting this feature. Just like npm allows something like - npm run unit-test:node -- --reporter "path to reporter.js" We don't have an equivalent for this in rush yet, look at issue - microsoft/rushstack#1232 (comment)
Given this, we'll let the CI as it is for now and update when we have the support in rush

@ramya-rao-a ramya-rao-a added EngSys This issue is impacting the engineering system. and removed triage labels Jul 20, 2020
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Jul 20, 2020
@kurtzeborn
Copy link
Member

It looks like the issue @KarishmaGhiya linked to above is still open, so the new feature is likely not available in rush yet. We should explore other options to accomplish what's being asked for here and make a recommendation back to @HarshaNalluru and @ramya-rao-a or close the issue if we don't see a way to accomplish this.

@KarishmaGhiya
Copy link
Contributor

Currently we do not have a way of allowing the reporter to run outside of npm scripts. For now i will close this.

@xirzec xirzec removed this from the Backlog milestone May 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

5 participants