Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Recorder] Take changes from mocha@7.0.0 #8110

Closed
HarshaNalluru opened this issue Mar 31, 2020 · 2 comments
Closed

[Recorder] Take changes from mocha@7.0.0 #8110

HarshaNalluru opened this issue Mar 31, 2020 · 2 comments
Assignees
@HarshaNalluru
Labels
Client This issue points to a problem in the data-plane of the library. test-utils-recorder Label for the issues related to the common recorder
Milestone
[2022] May

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Mar 31, 2020 •
edited

Previously, afterEach was skipped if the test is skipped, the behavior is changed with mocha@7.0.0, afterEach gets executed even if the test is skipped.

This breaks the playback tests since the skipped tests do not have the recordings for the HTTP requests in afterEach.

Update the tests with recordings so that we don't have to check if the test is pending in afterEach. ( !this.currentTest?.isPending() )

Reference - https://github.com/Azure/azure-sdk-for-js/pull/8108/files#r400580853
@HarshaNalluru HarshaNalluru mentioned this issue Mar 31, 2020
Merged
@HarshaNalluru HarshaNalluru added Client This issue points to a problem in the data-plane of the library. test-utils-recorder Label for the issues related to the common recorder labels Mar 31, 2020
@HarshaNalluru HarshaNalluru added this to the [2020] May milestone Mar 31, 2020
@ramya-rao-a ramya-rao-a modified the milestones: [2020] May, Backlog May 6, 2020
@HarshaNalluru HarshaNalluru mentioned this issue Jun 12, 2020
Closed
@HarshaNalluru
Copy link
Member Author

Related #9509

@HarshaNalluru HarshaNalluru self-assigned this Apr 5, 2022
@HarshaNalluru HarshaNalluru modified the milestones: Backlog, [2022] May Apr 5, 2022
@HarshaNalluru
Copy link
Member Author

Closing this as it is not relevant for recorder v2

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HarshaNalluru HarshaNalluru

Labels
Client This issue points to a problem in the data-plane of the library. test-utils-recorder Label for the issues related to the common recorder
Projects
None yet
Milestone
[2022] May
Development

No branches or pull requests
2 participants
@HarshaNalluru @ramya-rao-a