Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dev dependency @rollup/plugin-commonjs #9066

Closed
mikeharder opened this issue May 21, 2020 · 6 comments
Closed

Update dev dependency @rollup/plugin-commonjs #9066

mikeharder opened this issue May 21, 2020 · 6 comments
Assignees
@maorleger
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Milestone
[2021] December

Comments

@mikeharder
Copy link
Member

Dependency @rollup/plugin-commonjs was pinned to 11.0.2 in #9045, since 11.1.0 causes build breaks in our repo. The dependency should be updated to either 11.1.0 or the latest (currently 12.0.0).

https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md

CC: @HarshaNalluru
@mikeharder mikeharder added the Client This issue points to a problem in the data-plane of the library. label May 21, 2020
@xirzec
Copy link
Member

xirzec commented May 21, 2020

Is there an example of the output from the build break?

@HarshaNalluru
Copy link
Member

@xirzec

 Error: Dynamic requires are not currently supported by @rollup/plugin-commonjs

https://dev.azure.com/azure-sdk/public/_build/results?buildId=398738&view=logs&j=b4852f1b-cbff-5fc1-4b9a-0828dbc40956&t=8ca34846-5d9c-520f-8864-7ec996815e89

@mikeharder
Copy link
Member Author

mikeharder commented May 21, 2020 •
edited

We will also need the circular dependency fixes from this PR which were never merged:

#8642

These are needed for 11.1.0. I don't believe anyone has tried 12.0.0 yet.

@HarshaNalluru HarshaNalluru mentioned this issue May 29, 2020
Merged
@HarshaNalluru
Copy link
Member

For more reference, ongoing investigation in the draft PR #9074

@mikeharder mikeharder mentioned this issue Jun 3, 2020
Closed
@mikeharder mikeharder changed the title Update @rollup/plugin-commonjs Update dev dependency @rollup/plugin-commonjs Jun 5, 2020
@ramya-rao-a ramya-rao-a added this to the MQ-2020 milestone Nov 16, 2020
@willmtemple willmtemple mentioned this issue Dec 16, 2020
Closed
@ramya-rao-a ramya-rao-a modified the milestones: MQ-2020, [2021] February Dec 23, 2020
@witemple-msft witemple-msft self-assigned this Jan 6, 2021
@witemple-msft
Copy link
Member

Currently blocked on an upstream bug in @rollup/plugin-commonjs: rollup/plugins#743

Migrating to rollup 2 and the newer versions of plugin-commonjs will ease the transition to the shared rollup configuration, so this is related to that as well.

@witemple-msft witemple-msft modified the milestones: [2021] May, [2021] June Apr 15, 2021
@ramya-rao-a ramya-rao-a added the EngSys This issue is impacting the engineering system. label Jun 17, 2021
@ramya-rao-a ramya-rao-a modified the milestones: [2021] June, Backlog Jun 17, 2021
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, [2021] December Jul 26, 2021
@jeremymeng jeremymeng mentioned this issue Aug 24, 2021
Closed
@jeremymeng
Copy link
Contributor

Closing in favor of bot-auto-filed issue #19156

@jeremymeng jeremymeng mentioned this issue Dec 13, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maorleger maorleger

Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
[2021] December
Development

No branches or pull requests
8 participants
@xirzec @willmtemple @maorleger @jeremymeng @mikeharder @HarshaNalluru @ramya-rao-a @witemple-msft