Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

[AutoRest.Ruby] Inheritance usage of "Resource" is broken #957

Closed
vishrutshah opened this issue Sep 8, 2017 · 1 comment
Closed

[AutoRest.Ruby] Inheritance usage of "Resource" is broken #957

vishrutshah opened this issue Sep 8, 2017 · 1 comment
Assignees
Labels
ARM bug This issue requires a change to an existing behavior in the product in order to be resolved. investigating P0 Sprint-106 Sprint-107

Comments

@vishrutshah
Copy link
Contributor

vishrutshah commented Sep 8, 2017

MsRestAzure does not have a class ProxyOnlyResource . Inheritance logic is buggy

Example: https://github.com/Azure/azure-sdk-for-ruby/blob/master/management/azure_mgmt_web/lib/generated/azure_mgmt_web/models/backup_item.rb#L11

AutoRest Code: https://github.com/vishrutshah/autorest.ruby/blob/master/src/azure/Model/CompositeTypeRba.cs#L51

Last changes to that model: https://github.com/Azure/autorest/pull/1769/files#diff-817aab60d4b1d87bb4f496c78f25e473R76

Some of other related problems are the swagger has marked the model wrong as x-ms-azure-resource. model ResourceUpdate is not a valid x-ms-azure-resource.

@vishrutshah
Copy link
Contributor Author

Re-opening this as an issue did not get resolved correctly. This caused SubResource to not generate for azure_mgmt_datalake SDK for release of ARM 0.13.0.

Reverting this Azure/autorest.ruby#12

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ARM bug This issue requires a change to an existing behavior in the product in order to be resolved. investigating P0 Sprint-106 Sprint-107
Projects
None yet
Development

No branches or pull requests

2 participants