-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setters!() macro to use with_$name when rust issue is resolved #292
Comments
With the use of |
I'm unsure how I feel about this. The method names without the |
This was the result of a discussion around client options long ago. But given we've changed to builders this may no longer be relevant. Are we settled on builders, then? |
...and if we are, how do we "inherit" general client options, which we do for all other languages' SDKs? The idea is that we sometimes make changes to base client options that get fed into the pipeline and need to just "show up" on client library-specific client options. Last I remember, we never did settle on that when discussing using builders instead of what I proposed for client options originally. |
We aren't fully down transitioning clients to a builder pattern but that's certainly where we're heading. In Rust, you can mimic inheritance by just having the base client options be a field on the service specific client and (optionally) implement |
To be idiomatic we want to define functions generated by our
setters!()
macro to use the namewith_$name
. However, because of an open issue in rust we cannot yet, or need to use one of a few crates that make this possible.The text was updated successfully, but these errors were encountered: