Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Change MessagingEntityType to internal #39

Closed
SeanFeldman opened this issue Dec 15, 2016 · 5 comments
Closed

Change MessagingEntityType to internal #39

SeanFeldman opened this issue Dec 15, 2016 · 5 comments
Labels
Milestone

Comments

@SeanFeldman
Copy link
Collaborator

SeanFeldman commented Dec 15, 2016

Traditionally, this was limited to 4 entity types

  1. Queue
  2. Topic
  3. Subscription
  4. Filter

Entities would reside under Namespace.

With the new client, MessagingEntityType is adding Namespace as an entity. Is namespace truly an entity? Are different concerns mixed together?

@SeanFeldman
Copy link
Collaborator Author

Apperently, MessagingEntityType shouldn't have been made public to begin with.
Opened a separate issue (#40) for publicly exposed types.

@jtaubensee
Copy link
Contributor

You are correct. We will remove namespace as there are not currently any management operations, and we can also make the MessagingEntityType enum internal.

@SeanFeldman
Copy link
Collaborator Author

👍 for internalizing the enum. It shouldn't be public.
Which should be resolved with #40, eventually.

@jtaubensee
Copy link
Contributor

Marking this as a bug, to change MessagingEntityType to internal

@jtaubensee jtaubensee changed the title Is namespace considered an entity? Change MessagingEntityType to internal Mar 9, 2017
@jtaubensee jtaubensee added this to the 0.0.3-preview milestone Mar 9, 2017
@jtaubensee
Copy link
Contributor

Closing based on #124

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants