Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceConnectionNotActiveException from ServiceConnection.ProcessOutgoingMessagesAsync #1632

Closed
vicancy opened this issue Jun 24, 2022 · 0 comments · Fixed by #1631
Closed

Comments

@vicancy
Copy link
Member

vicancy commented Jun 24, 2022

Describe the bug

When the server connection is closed, if the Hub level writes data into the client connection Application Input, since it fails to deliver messages out through the server connection, ServiceConnectionNotActiveException throws

Details

ProcessOutgoingMessageAsync processes Application Input pipeline. When using AzureSignalR, messages such as GroupSend UserSend messages (actions going through lifetime manager) do not write into this pipeline but write into server connections directly. Messages written into the Application Input pipeline include: Ping, Completion, and StreamItem. https://github.com/dotnet/aspnetcore/blob/main/src/SignalR/docs/specs/HubProtocol.md

Improvements

Such exception logs worry our customers.

When the server connection is closed, the client connection routed to this server connection is closed. We can choose to stop the message delivery from server to service because anyway the client connection is already closed. Having a connection closed log should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant