New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime should be able to directly consume webjobs dlls #1508
Comments
Initial investigation looks promising. Just adding the compiled types to the TypeLoader in ScriptHost is enough to execute them. It looks like all of the Ref.Emit round-tripping is really to support the instrumentation that we have in FunctionInvoker.InvokeCore. But the SDK can provide a function begin/end hook to enable this instrumentation (Very similar to what we already do in fast-logger). |
I'd expect that bringing them in directly would work, but we need to address some of the scenarios we've discussed (e.g out of proc). I think we really need to consider going with a metadata only approach from an SDK's perspective, instead of using the attributes. We can't expect to be able to load and inspect those assemblies in all scenarios. |
Solving #578 will make this much easier because it addresses the issues we have around FunctionInvoker.InvokeCore. |
Yes. Ideally, we'd solve #578 in a way that removes the need for the metrics logic in |
Flagging this as potentially breaking. Here is how a customer gets broken:
If we don't want this to be breaking, the behavior has to go behind some type of flag, or we have to use function.json first and fallback to the attributes. Need to think about the exact semantics to use for the fallback. |
Resolution to break: VS tooling adds a property |
Removing the "engineering" label as it does have some customer impact, wrt to "isGenerated" |
This is similar to precompiled, but is enabled if Function.json includes a "configurationSource" : "attributes". All functions within an assembly need the same setting. Resolves #1508 Add test, which runs locally but disabled since it fails in appveyor.
This is similar to precompiled, but is enabled if Function.json includes a "configurationSource" : "attributes". All functions within an assembly need the same setting. Resolves #1508 Add test, which runs locally but disabled since it fails in appveyor.
The Functions runtime should be able to directly consume webjobs dlls.
Today when using VS tooling,
We should skip steps 2...4 and just consume the webjobs dll directly.
Notes by @lindydonna:
isGenerated
flag is missing or false, script runtime should fall back to the old behavior and use function.json.Tasks:
Support changes: (other bugs we need to fix already)
Process
The text was updated successfully, but these errors were encountered: