Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow binding to HTTP headers #591

Closed
brettsam opened this issue Aug 19, 2016 · 4 comments
Closed

Allow binding to HTTP headers #591

brettsam opened this issue Aug 19, 2016 · 4 comments
Assignees
Milestone

Comments

@brettsam
Copy link
Member

Can we expand binding to headers as well as the body and query string? Example -- someone has a third party library that sends requests with an id in the header. It'd be nice if they can bind to that directly -- http://stackoverflow.com/questions/39036629/for-azure-documentdb-input-binding-is-there-a-way-to-get-the-document-id-from-t

@mathewc
Copy link
Member

mathewc commented Aug 19, 2016

Perhaps. As part of merging in the http routing work, we'll also be expanding binding data to include route parameters, so we'll be doing more work in this area :)

@mathewc
Copy link
Member

mathewc commented Oct 12, 2016

Closing this, since I don't think we should allow binding to headers. If we get customer asks for this, we can revisit.

@mathewc mathewc closed this as completed Oct 12, 2016
@brettsam
Copy link
Member Author

Can you explain why we shouldn't do this? This issue was created due to a customer ask, which seemed like a pretty reasonable scenario, so it'd be good to capture the reasons to close it.

@mathewc
Copy link
Member

mathewc commented Oct 12, 2016

Sorry, I missed the SO link above. Unlike the route and query parameters, the headers collection can contain a lot of superfluous stuff that I don't think want to dump into the binding data bag.

I'll open this back up and assign back to triage so we can discuss further.

@mathewc mathewc reopened this Oct 12, 2016
@mathewc mathewc removed this from the Next - Triaged milestone Oct 12, 2016
@christopheranderson christopheranderson added this to the Next - Triaged milestone Oct 17, 2016
MikeStall added a commit to Azure/azure-webjobs-sdk that referenced this issue May 5, 2017
This supports dotting into Poco, JObject, and IDictionary.
It works nicely with Blob binding data (like metadata) and Queue and can be expanded to Http requests.

Supports:
Azure/azure-functions-host#591
Azure/azure-functions-host#1418
#798
@mathewc mathewc closed this as completed May 23, 2017
alrod pushed a commit to alrod/azure-functions-servicebus-extension that referenced this issue Jul 3, 2019
This supports dotting into Poco, JObject, and IDictionary.
It works nicely with Blob binding data (like metadata) and Queue and can be expanded to Http requests.

Supports:
Azure/azure-functions-host#591
Azure/azure-functions-host#1418
Azure/azure-webjobs-sdk#798
alrod pushed a commit to alrod/azure-functions-servicebus-extension that referenced this issue Jul 5, 2019
This supports dotting into Poco, JObject, and IDictionary.
It works nicely with Blob binding data (like metadata) and Queue and can be expanded to Http requests.

Supports:
Azure/azure-functions-host#591
Azure/azure-functions-host#1418
Azure/azure-webjobs-sdk#798
@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants