Allowing relative script file references #1132
Conversation
fabiocav
force-pushed
the
relscriptfile
branch
from
add3481
to
c84165f
Compare
fabiocav
changed the title
fabiocav
force-pushed
the
relscriptfile
branch
from
c84165f
to
40f8b1f
Compare
fabiocav
changed the title
|
Looks good! How will this interact with script host file watching? |
|
Good question! This would currently rely on |
fabiocav
changed the title
fabiocav
force-pushed
the
relscriptfile
branch
from
40f8b1f
to
4683a45
Compare
| string scriptPath = fileSystem.Path.Combine(scriptDirectory, scriptFileName); | ||
| if (!fileSystem.File.Exists(scriptPath)) | ||
| { | ||
| throw new ConfigurationErrorsException("Invalid script file name configuration. The 'scriptFileName' property is set to a file that does not exist."); |
There was a problem hiding this comment.
The property is called "scriptFile" right?
There was a problem hiding this comment.
Maybe rename local var to scriptFile, since it can actually be a path.
| @@ -0,0 +1,16 @@ | |||
| { | |||
| "scriptFile": "../HttpTrigger/index.js", | |||
There was a problem hiding this comment.
You used \ in a previous example, here you're using /. Intentional?
There was a problem hiding this comment.
It was.... just wanted to have a sample and test with the variation
fabiocav
force-pushed
the
relscriptfile
branch
2 times, most recently
from
f92c060
to
b9f6750
Compare
fabiocav
force-pushed
the
relscriptfile
branch
from
b9f6750
to
690b13d
Compare
This enables relative references to script files, primarily addressing the need to reference shared precompiled assemblies, but enabling this for other languages as well.
With this changes, relative references like this are now supported:
"scriptFile":"..\\shared\\myassembly.dll"