Adding a first class HttpBinding + binding data support #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "type": "blob", | ||
| "name": "outBlob", | ||
| "direction": "out", | ||
| "path": "samples-output/{Id}" |
There was a problem hiding this comment.
This didn't work before. Now you can bind to values from the payload.
| Dictionary<string, object> bindingData = new Dictionary<string, object>(StringComparer.OrdinalIgnoreCase); | ||
| if (request.Content != null && request.Content.Headers.ContentLength > 0) | ||
| { | ||
| string body = request.Content.ReadAsStringAsync().Result; |
There was a problem hiding this comment.
Should we make this method async (the caller is an async method as well) and await here to avoid .Result?
|
Took a quick first pass at this. Feels good to see this landing! :) |
mathewc
force-pushed
the
http-binding
branch
3 times, most recently
from
7e4e1c3
to
67f54a7
Compare
|
Merged. I'll address any additional feedback anyone has. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are being made to address the following bugs:
#334 HttpTrigger: Request object needs to be part of bindingdata
#230 C#: Extract binding data for HttpTrigger
Currently for C# there is no binding data support for HttpTrigger, meaning you can't use binding expressions in your output bindings that reference data from the request. We were able to work around this limitation in Node (and the other script languages) because bindings for those languages are late bound meaning we can inject the binding data before the bind happens. For C# we can't, since binding contract validation is done when the function method is loaded into the host (same as in core SDK scenarios).
To address this, I'm introducing a minimal HttpTrigger binding. The behavior is:
Languages other than C# should continue to work the way they do now, except that they'll also now have the ability to bind to query string parameters (when no body is sent).
I'm not planning on checking this in until AFTER iteration 20 is complete.