New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[socket.io] Doc issue #573

Open

chenkennt opened this issue Aug 4, 2023 · 0 comments

Labels

bugbash-socketio

Member

chenkennt commented Aug 4, 2023

In the migration doc, it says some APIs are changed from sync to async, but the code sample here doesn't make much difference:

io.on("connection", async (socket) => { await socket.join("room abc"); });

For this particular case it doesn't really matter whether you put await or not.

zackliu added the bugbash-socketio label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment