feat: add webhook support for init containers #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ernest Wong <chuwon@microsoft.com>
aramase
approved these changes
Aug 31, 2021
| // add the volume mount if not exists | ||
| pod.Spec.Containers[i] = addProjectedTokenVolumeMount(pod.Spec.Containers[i]) | ||
| } | ||
| pod.Spec.InitContainers = m.mutateContainers(pod.Spec.InitContainers, clientID, tenantID, skipContainers) |
There was a problem hiding this comment.
I think an interesting corner case is if the init container has the same name as a non-init container (which we should check if possible). If it's allowed, then skipping just the init/non-init container isn't an option. I don't think we need to support it but we should document using different name for init containers if Kubernetes allows using the same name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ernest Wong chuwon@microsoft.com
Reason for Change:
Add webhook support for init containers.
Requirements
Issue Fixed:
Fixes #149.
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: