Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use go install instead of depcreated go get #171

Merged
merged 1 commit into from
Sep 6, 2021
Merged

chore: use go install instead of depcreated go get #171

merged 1 commit into from
Sep 6, 2021

Conversation

chewong
Copy link
Contributor

@chewong chewong commented Sep 3, 2021

Signed-off-by: Ernest Wong chuwon@microsoft.com

Reason for Change:

Replace go getwith go install when installing tool binaries.

go get: installing executables with 'go get' in module mode is deprecated.
	To adjust and download dependencies of the current module, use 'go get -d'.
	To install using requirements of the current module, use 'go install'.
	To install ignoring the current module, use 'go install' with a version,
	like 'go install example.com/cmd@latest'.
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@@ -184,7 +184,14 @@ $(KIND):
GOBIN=$(TOOLS_BIN_DIR) $(GO_INSTALL) sigs.k8s.io/kind $(KIND_BIN) $(KIND_VER)

$(KUSTOMIZE):
GOBIN=$(TOOLS_BIN_DIR) $(GO_INSTALL) sigs.k8s.io/kustomize/kustomize/$(shell echo $(KUSTOMIZE_VER) | cut -d'.' -f1) $(KUSTOMIZE_BIN) $(KUSTOMIZE_VER)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go install does not work with kustomize for now:

go install: github.com/kubernetes-sigs/kustomize/kustomize/v4@v4.1.2 (in github.com/kubernetes-sigs/kustomize/kustomize/v4@v4.1.2):
        The go.mod file for the module providing named packages contains one or
        more exclude directives. It must not contain directives that would cause
        it to be interpreted differently than if it were the main module.

Switched to downloading the tarball.

Signed-off-by: Ernest Wong <chuwon@microsoft.com>
@chewong chewong merged commit 3d52e50 into Azure:main Sep 6, 2021
@chewong chewong deleted the use-go-install branch September 6, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants