chore: add makefile for msal-go demo image and update image in docs #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
chewong
reviewed
Oct 13, 2021
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
chewong
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com
Reason for Change:
aramase/dotnet:v0.4usesAZURE_TOKEN_FILEinstead of the newerAZURE_FEDERATED_TOKEN_FILEand will not work with newer versions of the webhook. This PR updates the demo image in quick start toaramase/msal-go:v0.6.0. The image will work forlinux/amd64,linux/arm64,windows/1809/amd64,windows/1903/amd64,windows/1909/amd64,windows/2004/amd64andwindows/ltsc2022/amd64.Requirements
Issue Fixed:
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: