Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add role definition id client for azwi #221

Merged
merged 1 commit into from
Oct 20, 2021
Merged

feat: add role definition id client for azwi #221

merged 1 commit into from
Oct 20, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Oct 19, 2021

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

  • Adds roledefinitions to azure client
    • Removes the hardcoded role definition ids

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes #216

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@aramase aramase requested a review from chewong as a code owner October 19, 2021 23:54
@aramase aramase enabled auto-merge (squash) October 20, 2021 00:06
pkg/cloud/roledefinitions.go Outdated Show resolved Hide resolved
pkg/cloud/roledefinitions.go Outdated Show resolved Hide resolved
pkg/cloud/roledefinitions.go Outdated Show resolved Hide resolved
@aramase aramase requested a review from chewong October 20, 2021 17:37
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase merged commit f16a302 into Azure:main Oct 20, 2021
@aramase aramase deleted the role-definition-id branch October 20, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add roledefinitions client
2 participants