Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add individual commands for phases #227

Merged
merged 2 commits into from
Nov 4, 2021
Merged

feat: add individual commands for phases #227

merged 2 commits into from
Nov 4, 2021

Conversation

chewong
Copy link
Contributor

@chewong chewong commented Oct 21, 2021

Signed-off-by: GitHub noreply@github.com

Reason for Change:

Follow up for #213. Adding individual commands for phases:

./bin/azwi sa create phase --help                                                                      
The "phase" command invokes a single phase of the create workflow

Usage:
  azwi serviceaccount create phase [command]

Available Commands:
  aad-application    Create Azure Active Directory (AAD) application and its underlying service principal
  federated-identity Create federated identity between the AAD application and the Kubernetes service account
  role-assignment    Create role assignment between the AAD application and the Azure cloud resource
  service-account    Create Kubernetes service account in the current KUBECONFIG context and add azure-workload-identity labels and annotations to it

Flags:
  -h, --help   help for phase

Global Flags:
      --auth-method string        auth method to use. Supported values: cli, client_secret, client_certificate (default "cli")
      --azure-env string          the target Azure cloud (default "AzurePublicCloud")
      --certificate-path string   path to client certificate (used with --auth-method=client_certificate)
      --client-id string          client id (used with --auth-method=[client_secret|client_certificate])
      --client-secret string      client secret (used with --auth-method=client_secret)
      --debug                     Enable debug logging
      --private-key-path string   path to private key (used with --auth-method=client_certificate)
  -s, --subscription-id string    azure subscription id (required)

Use "azwi serviceaccount create phase [command] --help" for more information about a command.
./bin/azwi sa delete phase --help
The "phase" command invokes a single phase of the delete workflow

Usage:
  azwi serviceaccount delete phase [command]

Available Commands:
  aad-application    Delete the Azure Active Directory (AAD) application and its underlying service principal
  federated-identity Delete federated identity for the AAD application and the Kubernetes service account
  role-assignment    Delete the role assignment between the AAD application and the Azure cloud resource
  service-account    Delete the Kubernetes service account in the current KUBECONFIG context

Flags:
  -h, --help   help for phase

Global Flags:
      --auth-method string        auth method to use. Supported values: cli, client_secret, client_certificate (default "cli")
      --azure-env string          the target Azure cloud (default "AzurePublicCloud")
      --certificate-path string   path to client certificate (used with --auth-method=client_certificate)
      --client-id string          client id (used with --auth-method=[client_secret|client_certificate])
      --client-secret string      client secret (used with --auth-method=client_secret)
      --debug                     Enable debug logging
      --private-key-path string   path to private key (used with --auth-method=client_certificate)
  -s, --subscription-id string    azure subscription id (required)

Use "azwi serviceaccount delete phase [command] --help" for more information about a command.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@chewong chewong requested a review from aramase as a code owner October 21, 2021 18:01
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
@chewong chewong requested a review from aramase November 4, 2021 17:31
@chewong chewong merged commit c94b4a9 into Azure:main Nov 4, 2021
@chewong chewong deleted the individual-phase-cmd branch November 4, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants