Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add debug logs for msal-go #257

Merged
merged 2 commits into from
Oct 28, 2021
Merged

chore: add debug logs for msal-go #257

merged 2 commits into from
Oct 28, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Oct 27, 2021

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

  • Adds debug logs for msal-go
    • Not using klog.Fatal as we want the pod to retry to fetch the token
  • For the other msal examples, we rise an exception for error which should provide more debug info

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes #248

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@aramase aramase requested a review from chewong as a code owner October 27, 2021 19:00
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase enabled auto-merge (squash) October 27, 2021 22:27
@aramase aramase merged commit bef6574 into Azure:main Oct 28, 2021
@chewong chewong deleted the example-debug-logs branch October 28, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add debug logs for token requests in the msal examples
2 participants