Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make azwi serviceaccount create|delete flags constant #274

Merged
merged 2 commits into from
Nov 9, 2021
Merged

chore: make azwi serviceaccount create|delete flags constant #274

merged 2 commits into from
Nov 9, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Nov 5, 2021

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

  • Make azwi serviceaccount create|delete constants
  • Adds error helper functions for generating error messages

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes #270

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@aramase aramase requested a review from chewong as a code owner November 5, 2021 18:17
@aramase aramase temporarily deployed to kind-e2e November 5, 2021 18:17 Inactive
@aramase aramase temporarily deployed to kind-e2e November 5, 2021 18:17 Inactive
@aramase aramase temporarily deployed to kind-e2e November 5, 2021 18:17 Inactive
@aramase aramase temporarily deployed to kind-e2e November 5, 2021 18:17 Inactive
@aramase aramase changed the title chore: make azwi serviceaccount create|delete flags constant chore: make azwi serviceaccount create|delete flags constant Nov 5, 2021
@aramase aramase temporarily deployed to azwi-e2e November 9, 2021 18:50 Inactive
@aramase aramase temporarily deployed to azwi-e2e November 9, 2021 18:57 Inactive
@aramase aramase temporarily deployed to azwi-e2e November 9, 2021 20:34 Inactive
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase temporarily deployed to azwi-e2e November 9, 2021 20:34 Inactive
@aramase aramase temporarily deployed to azwi-e2e November 9, 2021 21:07 Inactive
@aramase aramase enabled auto-merge (squash) November 9, 2021 21:07
@aramase aramase merged commit dc3a9c0 into Azure:main Nov 9, 2021
@aramase aramase deleted the const-flags branch November 9, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azwi serviceaccount create|delete flags should be constant
2 participants