Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add markdown-link-check workflow #283

Merged
merged 3 commits into from
Nov 11, 2021
Merged

ci: add markdown-link-check workflow #283

merged 3 commits into from
Nov 11, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Nov 10, 2021

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

  • Adds workflow for checking dead links in docs

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@aramase aramase temporarily deployed to azwi-e2e November 10, 2021 19:58 Inactive
@aramase aramase temporarily deployed to azwi-e2e November 10, 2021 20:09 Inactive
@aramase aramase temporarily deployed to azwi-e2e November 10, 2021 20:13 Inactive
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase temporarily deployed to azwi-e2e November 10, 2021 20:16 Inactive
@aramase aramase temporarily deployed to azwi-e2e November 10, 2021 20:32 Inactive
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase temporarily deployed to azwi-e2e November 10, 2021 20:36 Inactive
{
"ignorePatterns": [
{
"pattern": "^https://github.com/Azure/azure-workload-identity"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring this pattern because the repo is private and links return 404. We can remove this pattern when the repo is made public.

@aramase aramase marked this pull request as ready for review November 10, 2021 20:38
Copy link
Contributor

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much needed!

@aramase aramase temporarily deployed to azwi-e2e November 11, 2021 17:16 Inactive
@aramase aramase enabled auto-merge (squash) November 11, 2021 17:16
@aramase aramase merged commit c90ffd0 into Azure:main Nov 11, 2021
@aramase aramase deleted the markdown-link-check branch November 11, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants