Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: set subscription after login #295

Merged
merged 1 commit into from
Dec 13, 2021
Merged

test: set subscription after login #295

merged 1 commit into from
Dec 13, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Dec 11, 2021

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

Fixes nightly run failures: https://dev.azure.com/AzureContainerUpstream/Azure%20Workload%20Identity/_build/results?buildId=33438&view=results where the wrong sub is being chosen. Setting the subscription after login to make it more deterministic.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:
Added AZURE_SUBSCRIPTION_ID to the library here: https://dev.azure.com/AzureContainerUpstream/Azure%20Workload%20Identity/_library?itemType=VariableGroups&view=VariableGroupView&variableGroupId=26&path=e2e-environment-variables

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase temporarily deployed to azwi-e2e December 11, 2021 00:22 Inactive
@aramase aramase enabled auto-merge (squash) December 11, 2021 01:11
@aramase aramase merged commit c82d2fc into Azure:main Dec 13, 2021
@chewong chewong deleted the sub-id branch December 13, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants