Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: decrease ginkgo nodes to 1 to reduce flakiness #297

Merged
merged 1 commit into from
Dec 14, 2021
Merged

test: decrease ginkgo nodes to 1 to reduce flakiness #297

merged 1 commit into from
Dec 14, 2021

Conversation

chewong
Copy link
Contributor

@chewong chewong commented Dec 13, 2021

Signed-off-by: GitHub noreply@github.com

Reason for Change:

  • reduce the flakiness by running the test serially instead of in parallel.
  • add 3 worker nodes to our kind clusters to resemble real-world clusters.
  • e2e will stop depending on unit test to speed up pr gates by 8 minutes.
  • bump golanglint-ci to v1.43.0.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@chewong chewong temporarily deployed to azwi-e2e December 13, 2021 21:23 Inactive
@chewong chewong temporarily deployed to azwi-e2e December 13, 2021 21:57 Inactive
@chewong chewong temporarily deployed to azwi-e2e December 13, 2021 22:39 Inactive
@chewong chewong temporarily deployed to azwi-e2e December 13, 2021 23:34 Inactive
@chewong chewong temporarily deployed to azwi-e2e December 14, 2021 01:15 Inactive
@chewong chewong temporarily deployed to azwi-e2e December 14, 2021 18:57 Inactive
@chewong chewong temporarily deployed to azwi-e2e December 14, 2021 19:43 Inactive
Signed-off-by: GitHub <noreply@github.com>
@chewong chewong temporarily deployed to azwi-e2e December 14, 2021 20:16 Inactive
@chewong chewong marked this pull request as ready for review December 14, 2021 21:30
@chewong
Copy link
Contributor Author

chewong commented Dec 14, 2021

The aks_windows_containerd job flaked due to the error from azure-cli. Let me re-run.

@chewong chewong enabled auto-merge (squash) December 14, 2021 21:47
@chewong chewong merged commit 9a47548 into Azure:main Dec 14, 2021
@chewong chewong deleted the ginkgo-node-1 branch December 14, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants