Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Failed pipeline] avm.res.container-service.managed-cluster #1966

Open
avm-team-linter bot opened this issue May 17, 2024 · 15 comments
Open

[Failed pipeline] avm.res.container-service.managed-cluster #1966

avm-team-linter bot opened this issue May 17, 2024 · 15 comments
Assignees
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working

Comments

@avm-team-linter
Copy link

Failed run: https://github.com/Azure/bicep-registry-modules/actions/runs/9111902021

@avm-team-linter avm-team-linter bot added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working labels May 17, 2024
Copy link
Author

Important

@Azure/avm-res-containerservice-managedcluster-module-owners-bicep, the workflow for the avm/res/container-service/managed-cluster module has failed. Please investigate the failed workflow run. If you are not able to do so, please inform the AVM core team to take over.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label May 17, 2024
Copy link
Author

Copy link
Author

Copy link
Author

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label May 29, 2024
Copy link
Author

Copy link
Author

@AlexanderSehr
Copy link
Contributor

Hey @JPEasier,
please note that the 'azure' test in the pipeline throws the error

  Status Message: The template deployment '5qnklvrpzo22s-test-csmaz-init' is not valid according to the validation procedure. The tracking id is '0729f6f3-be74-4df7-b414-26b5064394fc'. See inner errors for details. (Code: InvalidTemplateDeployment)
   - Preflight validation check for resource(s) for container service ***csmaz001 in resource group dep-***-containerservice.managedclusters-csmaz-rg failed. Message: Preview feature Microsoft.ContainerService/AzureMonitorAppMonitoringPreview not registered.. Details:  (Code:PreviewFeatureNotRegistered)

Was that something that was recently added to the module?

@PixelRobots
Copy link
Contributor

Yes it was as part of the API version update. I can remove this part and push the changes tomorrow.

@AlexanderSehr
Copy link
Contributor

Not sure if just removing the feature again should be the first action - if it was added before on purpose 😄
@JPEasier & @ilhaan, please advice 😉

@PixelRobots
Copy link
Contributor

Just checked it was added before my change by the looks.

@AlexanderSehr AlexanderSehr linked a pull request Jun 3, 2024 that will close this issue
8 tasks
@eriqua
Copy link
Contributor

eriqua commented Jun 3, 2024

@JPEasier @ilhaan if a preview feature has been integrated into the module the following is required:

In addition, I'd highly recommend adding relevant info about the prerequisites to the readme notes section.

I'd suggest blocking the PR until the above is addressed/agreed upon.

Copy link
Author

@eriqua eriqua added Needs: Module Owner 📣 This module needs an owner to develop or maintain it and removed Needs: Triage 🔍 Maintainers need to triage still labels Jun 6, 2024
@Jaykul
Copy link

Jaykul commented Jun 6, 2024

Randomly: all of my AKS deploys are failing for this too, I think this was a broken change to AKS, not your change.

@AlexanderSehr
Copy link
Contributor

AlexanderSehr commented Jun 7, 2024

Randomly: all of my AKS deploys are failing for this too, I think this was a broken change to AKS, not your change.

Well, that's fun... 👀

Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
Status: Needs: Triage
Development

No branches or pull requests

5 participants