Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: Landing Zone Subscription Vending - avm/ptn/lz/sub-vending #2340

Open
1 task done
Dylan-Prins opened this issue Jun 12, 2024 · 6 comments
Open
1 task done
Assignees
Labels
Status: Long Term ⏳ We will do it, but will take a longer amount of time due to complexity/priorities Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@Dylan-Prins
Copy link

Dylan-Prins commented Jun 12, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/ptn/lz/sub-vending

(Optional) Module Version

No response

Description

Hi Jack,

With every landing zone deployment we also deploy a PIM role. is this something we can implement in lz-sub-vending as well?
This makes the roleassignment we deploy with the landing zone a little bit more secure.

ref: assign-azure-privileged-identity-management-roles-using-bicep

(Optional) Correlation Id

No response

@Dylan-Prins Dylan-Prins added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels Jun 12, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the AVM Issue Triage documentation.

@matebarabas
Copy link
Contributor

@Dylan-Prins, thanks for submitting this issue. As this is related to an existing module, I'm converting it to a module issue, and moving it to the BRM repo (where the modules' code reside).

To open an issue specific to an existing module, please submit a module issue (https://aka.ms/AVM/Bicep/ModuleIssue). You can also do this by selecting the Bicep module issue option on the new issues page:
image

@matebarabas matebarabas transferred this issue from Azure/Azure-Verified-Modules Jun 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Jun 12, 2024
@matebarabas matebarabas changed the title [Module Proposal]: Landing Zone Subscription Vending [AVM Module Issue]: Landing Zone Subscription Vending - avm/ptn/lz/sub-vending Jun 12, 2024
@matebarabas matebarabas added Type: Feature Request ➕ New feature or request and removed Status: Owners Identified 🤘 Type: New Module Proposal 💡 A new module for AVM is being proposed labels Jun 12, 2024
@jtracey93
Copy link
Contributor

Hey @Dylan-Prins,

great ask and one we already had on the backlog pre AVM: Azure/bicep-lz-vending#35

We will indeed get this done as well as constrained delegation for RBAC

@jtracey93 jtracey93 added the Status: Long Term ⏳ We will do it, but will take a longer amount of time due to complexity/priorities label Jun 14, 2024
@Dylan-Prins
Copy link
Author

Nice! Should have checked the other repo first... sorry for that

This comment was marked as outdated.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Jun 19, 2024
@AlexanderSehr

This comment was marked as off-topic.

@jtracey93 jtracey93 removed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Long Term ⏳ We will do it, but will take a longer amount of time due to complexity/priorities Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
Status: Needs: Triage
Development

No branches or pull requests

5 participants