-
Notifications
You must be signed in to change notification settings - Fork 19
/
clusterresourceoverride.go
93 lines (80 loc) · 3.44 KB
/
clusterresourceoverride.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
/*
Copyright (c) Microsoft Corporation.
Licensed under the MIT license.
*/
// Package validator provides utils to validate ClusterResourceOverride resources.
package validator
import (
"fmt"
"k8s.io/apimachinery/pkg/util/errors"
fleetv1alpha1 "go.goms.io/fleet/apis/placement/v1alpha1"
fleetv1beta1 "go.goms.io/fleet/apis/placement/v1beta1"
)
// ValidateClusterResourceOverride validates cluster resource override fields and returns error.
func ValidateClusterResourceOverride(cro fleetv1alpha1.ClusterResourceOverride, croList *fleetv1alpha1.ClusterResourceOverrideList) error {
allErr := make([]error, 0)
// Check if the resource is being selected by resource name
if err := validateClusterResourceSelectors(cro); err != nil {
// Skip other checks because the check is only valid if resource is selected by name
return err
}
// Check if the override count limit for the resources has been reached
if err := validateClusterResourceOverrideResourceLimit(cro, croList); err != nil {
allErr = append(allErr, err)
}
if cro.Spec.Policy != nil {
if err := validateOverridePolicy(cro.Spec.Policy); err != nil {
allErr = append(allErr, err)
}
}
return errors.NewAggregate(allErr)
}
// validateClusterResourceSelectors checks if override is selecting resource by name.
func validateClusterResourceSelectors(cro fleetv1alpha1.ClusterResourceOverride) error {
selectorMap := make(map[fleetv1beta1.ClusterResourceSelector]bool)
allErr := make([]error, 0)
for _, selector := range cro.Spec.ClusterResourceSelectors {
// Check if the resource is not being selected by label selector
if selector.LabelSelector != nil {
allErr = append(allErr, fmt.Errorf("label selector is not supported for resource selection %+v", selector))
continue
} else if selector.Name == "" {
allErr = append(allErr, fmt.Errorf("resource name is required for resource selection %+v", selector))
continue
}
// Check if there are any duplicate selectors
if selectorMap[selector] {
allErr = append(allErr, fmt.Errorf("resource selector %+v already exists, and must be unique", selector))
}
selectorMap[selector] = true
}
return errors.NewAggregate(allErr)
}
// validateClusterResourceOverrideResourceLimit checks if there is only 1 cluster resource override per resource,
// assuming the resource will be selected by the name only.
func validateClusterResourceOverrideResourceLimit(cro fleetv1alpha1.ClusterResourceOverride, croList *fleetv1alpha1.ClusterResourceOverrideList) error {
// Check if croList is nil or empty, no need to check for resource limit
if croList == nil || len(croList.Items) == 0 {
return nil
}
overrideMap := make(map[fleetv1beta1.ClusterResourceSelector]string)
// Add overrides and its selectors to the map
for _, override := range croList.Items {
selectors := override.Spec.ClusterResourceSelectors
for _, selector := range selectors {
overrideMap[selector] = override.GetName()
}
}
allErr := make([]error, 0)
// Check if any of the cro selectors exist in the override map
for _, croSelector := range cro.Spec.ClusterResourceSelectors {
if overrideMap[croSelector] != "" {
// Ignore the same cluster resource override
if cro.GetName() == overrideMap[croSelector] {
continue
}
allErr = append(allErr, fmt.Errorf("invalid resource selector %+v: the resource has been selected by both %v and %v, which is not supported", croSelector, cro.GetName(), overrideMap[croSelector]))
}
}
return errors.NewAggregate(allErr)
}