Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argo operator code missing kind argument for GitCommitStatus dataclass #19

Closed
plaisted opened this issue Jul 29, 2021 · 3 comments · Fixed by #22
Closed

Argo operator code missing kind argument for GitCommitStatus dataclass #19

plaisted opened this issue Jul 29, 2021 · 3 comments · Fixed by #22
Assignees

Comments

@plaisted
Copy link

Operator constructs GitCommitStatus below:

    def _new_git_commit_status(self, commit_id, status_name, state, message: str):
        return GitCommitStatus(commit_id=commit_id,
            status_name=status_name,
            state=state,
            message=message,
            callback_url=self.callback_url,
            gitops_operator='ArgoCD')

Errors with follow when event notification is received:

  File "/app/operators/argo_gitops_operator.py", line 60, in _new_git_commit_status
    return GitCommitStatus(commit_id=commit_id,
TypeError: __init__() missing 1 required positional argument: 'genre'

The flux operator does not have this issue.

@eedorenko eedorenko self-assigned this Jul 30, 2021
@plaisted
Copy link
Author

plaisted commented Jul 30, 2021

Also looks like _get_deployment_status_summary is missing, called by argocd operator:

(health_summary, sync_summary) = self._get_deployment_status_summary(phase_data['resources'])

@eedorenko
Copy link
Collaborator

Thanks a lot for the reported bug!

@plaisted
Copy link
Author

ty, will give the updated image a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants