Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit all composite types to ensure they properly implement non-mandatory fields #107

Open
jhendrixMSFT opened this issue Nov 23, 2021 · 1 comment

Comments

@jhendrixMSFT
Copy link
Member

jhendrixMSFT commented Nov 23, 2021

Per http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-types-v1.0-os.html#doc-idp115568

mandatory: "true" iff a non null value for the field is always encoded.

What this means is that for all non-mandatory fields in a composite type, they must be pointer-to-type. That said, we should be smart in how we fix things up. E.g. the description field in the error type isn't mandatory, however making it be *string doesn't really add any value.

@richardpark-msft
Copy link
Member

(related: #93)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants