Missing serial number arithmetic

[ansd]

In AMQP 1.0, a delivery-number is a 32-bit RFC-1982 serial number.
The DISPOSITION frame includes fields first and last.
first is the lower bound of delivery-ids to be (n)acked.
last is the upper bound of delivery-ids to be (n)acked.

To provide an example:
Serial number arithmetic defines sequence number 1 to be greater than sequence number 4294967294 (= 2^32-2) .
Therefore my understanding is that a DISPOSITION frame with first = 4294967294 and last = 1 is allowed and refers to delivery-numbers 4294967294, 4294967295, 0, and 1.

Is my understanding correct?

If yes, aren't

go-amqp/session.go

Line 418 in 1c1e489

for deliveryID := start; deliveryID <= end; deliveryID++ {

and

go-amqp/session.go

Line 708 in 1c1e489

for deliveryID := start; deliveryID <= end; deliveryID++ {

flawed? These lines need to perform serial number arithmetic instead of integer arithmetic?

[ansd]

In other words, there are bugs when acking / nacking messages with this client when the delivery ID wraps around.

The .NET client does the right thing in https://github.com/Azure/amqpnetlite/blob/772d0d3b6bbc43cf64e0ccd25911317f011927d7/src/Session.cs#L650 because they overwrite the comparison operators in https://github.com/Azure/amqpnetlite/blob/772d0d3b6bbc43cf64e0ccd25911317f011927d7/src/SequenceNumber.cs#L94-L98 to perform serial number arithmetic.