Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to add additional tags in reservation #84

Closed
XtratusCloud opened this issue Feb 21, 2023 · 6 comments
Closed

Allow to add additional tags in reservation #84

XtratusCloud opened this issue Feb 21, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@XtratusCloud
Copy link

XtratusCloud commented Feb 21, 2023

Is your feature request related to a problem? Please describe.
In our organization the number of pending reservations starts to be high, and the list displayed leaves no evidence of the project or architecture for which it has been requested.

Describe the solution you'd like
Allow to include additional tags when creating the reservation via API, and display this tags in the UI in one additional column

Additional context
We currently have it already implemented in the following commit (in our repository),
XtratusCloud@de57542

which includes the following:

  • Allow to add "tags" in the boyd of POST reservation request to API
    image

  • Manage the tag content in the reservation class, in models:
    image

  • And finally, add an additional column in UI, in the reservation windows, to display the tags.
    image

@DCMattyG
Copy link
Contributor

Hello @XtratusCloud, thanks so much for submitting this feature request!

First and foremost, I love this and I'm happy to incorporate this into Azure IPAM.

Couple of things:

  1. The term "tags" is a very Azure/Cloud specific term. Would it make more sense to call the additional field "metadata" which woulda align with other API's that already exist within Azure IPAM?
  2. Displaying a huge list of Key/Value pairs in a tiny column as you've shown in your mocked-up UI above doesn't feel like the best way to bubble this data up to the UI. I would imaging this can be extremely hard to ready, especially if users had a significant number of "tags" or "metadata" they were passing in.

Do you think an arbitrary dictionary of key/value pairs makes sense here? What type of data are YOU using this for, and could those same purposes be applied to other users (e.g. is this only a description, or is there something else that is important here)?

Very much appreciate the feedback and I'm quite sure we can get this folded in right away. Let's just make sure we're thinking through the proposed structure and it's intended use cases together. Thanks!

@DCMattyG DCMattyG self-assigned this Feb 21, 2023
@XtratusCloud
Copy link
Author

Hi @DCMattyG , thanks for your quick response.

Totally agree about using the term "metadata" instead of "tags",
I used the "tag" concept because I see that the application already uses it, and I intended to implement the functionality I need being the most minimally invasive, but any option would be valid for us.

Basically what we need is a simple description, which could be achieved by adding a simple text field.

Totally agree that displaying a tooltip on a floating window is not the most stylish and practical UI implementation ;)
We will adapt to the implementation that you consider most optimal, and will align the terraform provider to it.

Thanks!!

@DCMattyG
Copy link
Contributor

Thanks for the feedback @XtratusCloud!

In that case does it make sense just to add an optional description field to the API, or is there a need where a number of key/value pairs would need to be appended?

@XtratusCloud
Copy link
Author

Hi @DCMattyG ,
We only needs to be able to add a description to the reservation, a text field would be fine.
But if you think that adding a "metadata" collection could be useful for other users, will also be good.

Thanks!!

@DCMattyG DCMattyG added the enhancement New feature or request label Apr 12, 2023
@XtratusCloud
Copy link
Author

I have tested the existing implementation in the "vwan-support" branch, which allows you to specify a description when creating a reservation, and it covers our needs perfectly.

@DCMattyG , this request can be closed at your convenience.

@DCMattyG
Copy link
Contributor

Hi @XtratusCloud, this is now completed and had been merged into main via PR #113. Thank you for all of your support in bringing this feature into Azure IPAM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants