Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Disk Encryption Set for Node OS Disks #268

Open
iamvighnesh opened this issue Apr 15, 2024 · 3 comments
Open

Support Disk Encryption Set for Node OS Disks #268

iamvighnesh opened this issue Apr 15, 2024 · 3 comments
Labels
area/security Issues or PRs related to security area/storage Issues or PRs related to storage triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@iamvighnesh
Copy link
Contributor

Tell us about your request

The users are requesting support for Disk Encryption Sets for Node OS Disks on Karpenter-managed nodes.

Here's the existing feature for AKS managed nodes with Disk Encryption Set for Node OS Disks.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

The users do not have a way to provide a customer-managed key for encrypting node OS disk and would like the ability to supply customer-managed keys to use for encryption at rest for both the OS for Karpenter-managed nodes.

Are you currently working around this issue?

No workaround is available for this right now.

Additional Context

  • Do we also need to consider supporting Host Encryption for the nodes?
  • Right now, Disk Encryption Set can only be enabled during cluster creation. We need to investigate how that would affect the karpenter-managed nodes.
  • What happens if the AKS cluster does not have Disk Encryption Set enabled?

Attachments

No response

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@tallaxes
Copy link
Collaborator

This is currently not supported. The first step would be to enable disk encryption with managed keys by default, which is what AKS does. Next step would be support for BYOK.

@tallaxes tallaxes added triage/accepted Indicates an issue or PR is ready to be actively worked on. area/storage Issues or PRs related to storage area/security Issues or PRs related to security labels Apr 25, 2024
@iamvighnesh
Copy link
Contributor Author

@tallaxes Would you like me create a separate issue for Disk Encryption using platform managed keys?

I am happy to pick this up and work on both the features.

@tallaxes
Copy link
Collaborator

Good idea, and appreciate offer of help! Let me dig a little bit into the differences between this (server-side encryption) and host-based encryption, to see how to break this down best - and maybe set priorities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security Issues or PRs related to security area/storage Issues or PRs related to storage triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants