Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VNET Contributor CLI Role Assignment #332

Open
Bryce-Soghigian opened this issue May 7, 2024 · 0 comments
Open

VNET Contributor CLI Role Assignment #332

Bryce-Soghigian opened this issue May 7, 2024 · 0 comments
Assignees
Labels
area/networking Issues or PRs related to networking

Comments

@Bryce-Soghigian
Copy link
Collaborator

Tell us about your request

For the traditional aks experience with CustomVNET, when you create clusters with the cli, we use the customers credential to assign all the roles needed for the subnet here

  • Microsoft.Network/virtualNetworks/subnets/join/action
  • Microsoft.Network/virtualNetworks/subnets/read

But Unlike traditional AKS, Karpenter needs some additional vnet permissions. We need to be able to GET the vnet as well.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

We need to modify the azure cli to also include role assignments that karpenter needs for NAP. We rg level scoped rbac for vnet read. Or we could solve all of the network contribution perms by assigning Virtual Network Contributor to the cluster identity.

Are you currently working around this issue?

https://github.com/Azure/karpenter-provider-azure/pull/326/files

$(eval CLUSTER_IDENTITY_ID=$(shell az aks show --name $(AZURE_CLUSTER_NAME) --resource-group $(AZURE_RESOURCE_GROUP) | jq  -r ".identity.principalId"))
az role assignment create --assignee $(CLUSTER_IDENTITY_ID) --scope /subscriptions/$(AZURE_SUBSCRIPTION_ID)/resourceGroups/$(AZURE_RESOURCE_GROUP) --role "Network Contributor"

Additional Context

No response

Attachments

No response

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@Bryce-Soghigian Bryce-Soghigian added the area/networking Issues or PRs related to networking label May 7, 2024
@Bryce-Soghigian Bryce-Soghigian self-assigned this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking Issues or PRs related to networking
Projects
None yet
Development

No branches or pull requests

1 participant