Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding subnet selector functionality #333

Open
midaslmg94 opened this issue May 8, 2024 · 1 comment
Open

Adding subnet selector functionality #333

midaslmg94 opened this issue May 8, 2024 · 1 comment
Labels
triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@midaslmg94
Copy link

Tell us about your request

I am currently working with the AKSNodeClasses CRD, which only includes the properties imageFamily, imageVersion, osDiskSizeGB, and tags. For enhanced functionality, it would be beneficial to add a subnetSelector property.

This addition would enable scaling nodes within specific subnets, a feature not currently supported by AKSNodeClasses. I noticed that EC2NodeClass already supports this through subnetSelectorTerms (as detailed here: Karpenter Documentation). Implementing a similar functionality in AKSNodeClasses could provide more flexibility and control over node deployment in various subnet environments.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

no

Are you currently working around this issue?

no

Additional Context

No response

Attachments

No response

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@Bryce-Soghigian
Copy link
Collaborator

Bryce-Soghigian commented May 8, 2024

Hi @midaslmg94 thanks for opening an issue! I am working on adding subnet support per nodeclass. The PR for this is out and can be viewed here: https://github.com/Azure/karpenter-provider-azure/pull/314/files.

This would allow you to specify a subnet in the AKSNodeClass via the subnets ARM Resource ID. We will not be supporting tags based selection, but you will be able to specify a subnet per nodeclass.

Is this sufficient? Does it solve for your usecase?

@Bryce-Soghigian Bryce-Soghigian added the triage/needs-information Indicates an issue needs more information in order to work on it. label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

No branches or pull requests

2 participants