Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSAL Migration] device code flow is not supported in Managed Device in Conditional Access #62

Closed
weinong opened this issue Apr 22, 2021 · 12 comments

Comments

@weinong
Copy link
Contributor

weinong commented Apr 22, 2021

The limitation is documented here.

The fix is to adopt auth code grant flow

Sample code: https://github.com/Azure/azure-sdk-for-go/blob/master/sdk/azidentity/interactive_browser_credential.go

@weinong
Copy link
Contributor Author

weinong commented Apr 28, 2021

pending on token cache feature in Azure/azure-sdk-for-go#6602

@weinong
Copy link
Contributor Author

weinong commented Feb 4, 2022

@weinong weinong changed the title device code flow is not supported in Managed Device in Conditional Access [MSAL Migration] device code flow is not supported in Managed Device in Conditional Access Feb 4, 2022
@weinong
Copy link
Contributor Author

weinong commented Feb 4, 2022

@weinong
Copy link
Contributor Author

weinong commented Feb 16, 2022

@aelij
Copy link
Member

aelij commented Sep 3, 2022

The device code flow is much less convenient than interactive browser, so please migrate.

Additionally, ADAL has been deprecated and will no longer receive security updates:

If you choose not to migrate to MSAL before ADAL support ends in December, 2022, you put your app's security at risk.

@weinong
Copy link
Contributor Author

weinong commented Sep 6, 2022

Hi @aelij, yes, completely agree with you. I'm ramping up a new hire on this project. Hopefully we can tackle it soon. Though, I'm curious to learn what "inconvenience" you are referring to?

@aelij
Copy link
Member

aelij commented Sep 7, 2022

The fact that you have to copy the device code, open the browser, paste it and login, rather than having the browser simply open :)

@weinong
Copy link
Contributor Author

weinong commented Oct 28, 2022

@fherbert
Copy link

Any update on the progress to migrate kubelogin to MSAL?

Would changing to MSAL result in the access_token be included in the _claim_sources member when a distrubted claim is returned?

We can't use kubelogin with anything other than AKS due to this limitation when users have more than 200 groups.

@weinong
Copy link
Contributor Author

weinong commented Oct 2, 2023

@fherbert we have some login modes implemented in msal such as interactive. Though, none of this would help you. That being said, I'd recommend configure your AAD app and k8s to use app roles for authorization instead of using groups

@weinong
Copy link
Contributor Author

weinong commented Oct 2, 2023

closing this issue as web interactive login mode is compatible with conditional access policy

@weinong weinong closed this as completed Oct 2, 2023
@aelij
Copy link
Member

aelij commented Dec 17, 2023

@weinong I think you should keep this open until ADAL is fully removed from the repo (or track in a different issue). The library was deprecated a while ago and presents a security risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants