Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github is deprecating node16 on actions #391

Closed
eikooc opened this issue Dec 28, 2023 · 3 comments
Closed

Github is deprecating node16 on actions #391

eikooc opened this issue Dec 28, 2023 · 3 comments
Assignees
@YanaXu
Labels
dependencies Pull requests that update a dependency file

Comments

@eikooc
Copy link

eikooc commented Dec 28, 2023

Node 16 has reached End of Life (EoL)

Github supports node version 20 and we should move to use that instead

login/action.yml

Line 41 in 45c3280

using: 'node16'

@eikooc eikooc mentioned this issue Dec 28, 2023
Closed
@YanaXu YanaXu self-assigned this Dec 28, 2023
@YanaXu YanaXu added the dependencies Pull requests that update a dependency file label Dec 28, 2023
@YanaXu
Copy link
Collaborator

YanaXu commented Dec 28, 2023

@eikooc thanks for your suggestion. You're right. And it's in our plan.

@YanaXu
Copy link
Collaborator

YanaXu commented Dec 28, 2023

I'll close this issue since it's already tracked in #357.

@YanaXu YanaXu closed this as completed Dec 28, 2023
@eikooc
Copy link
Author

eikooc commented Dec 28, 2023

Sorry, I totally missed that. I've made a PR that updates the action #392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YanaXu YanaXu

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eikooc @YanaXu