Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: early stopping test and average precision metric #1034

Merged

Conversation

imatiach-msft
Copy link
Contributor

  • re-enable early stopping test
  • add average precision metric to comparison logic for early stopping

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft imatiach-msft changed the title fix early stopping test and average precision metric fix: early stopping test and average precision metric Apr 30, 2021
@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #1034 (f37b231) into master (04a9876) will increase coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1034      +/-   ##
==========================================
+ Coverage   84.50%   84.88%   +0.38%     
==========================================
  Files         203      203              
  Lines        9639     9640       +1     
  Branches      585      559      -26     
==========================================
+ Hits         8145     8183      +38     
+ Misses       1494     1457      -37     
Impacted Files Coverage Δ
...a/com/microsoft/ml/spark/lightgbm/TrainUtils.scala 86.40% <100.00%> (+9.13%) ⬆️
...m/microsoft/ml/spark/lightgbm/LightGBMParams.scala 89.57% <0.00%> (+1.42%) ⬆️
.../microsoft/ml/spark/lightgbm/LightGBMBooster.scala 89.06% <0.00%> (+1.56%) ⬆️
...com/microsoft/ml/spark/core/contracts/Params.scala 95.65% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04a9876...f37b231. Read the comment docs.

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft imatiach-msft merged commit aad223e into microsoft:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants