Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve LGBM error message for invalid slot names #1160

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

mhamilton723
Copy link
Collaborator

No description provided.

@mhamilton723
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

imatiach-msft
imatiach-msft previously approved these changes Aug 10, 2021
@@ -41,6 +42,20 @@ class VerifyLightGBMRegressor extends Benchmarks
super.testSerialization()
}

test("foo") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #1160 (49e7615) into master (448f893) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1160      +/-   ##
==========================================
- Coverage   83.82%   83.81%   -0.01%     
==========================================
  Files         259      259              
  Lines       12414    12413       -1     
  Branches      647      632      -15     
==========================================
- Hits        10406    10404       -2     
- Misses       2008     2009       +1     
Impacted Files Coverage Δ
...com/microsoft/ml/spark/lightgbm/LightGBMBase.scala 94.85% <100.00%> (-0.03%) ⬇️
...a/com/microsoft/ml/spark/io/http/HTTPClients.scala 56.66% <0.00%> (-3.34%) ⬇️
...rosoft/ml/spark/stages/PartitionConsolidator.scala 95.74% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 448f893...49e7615. Read the comment docs.

@mhamilton723
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit 8ec07e7 into microsoft:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants