Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add more E2E test to pipeline #1683

Merged
merged 36 commits into from Nov 16, 2022
Merged

test: Add more E2E test to pipeline #1683

merged 36 commits into from Nov 16, 2022

Conversation

k-rush
Copy link
Contributor

@k-rush k-rush commented Oct 19, 2022

Related Issues/PRs

What changes are proposed in this pull request?

Adding tests for synapse extension.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

@k-rush
Copy link
Contributor Author

k-rush commented Oct 19, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@github-actions
Copy link

Hey @k-rush 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

@k-rush
Copy link
Contributor Author

k-rush commented Oct 19, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022 •
edited

Codecov Report

Merging #1683 (0cb4bb5) into master (2a7a67b) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1683      +/-   ##
==========================================
+ Coverage   85.79%   85.82%   +0.02%     
==========================================
  Files         277      277              
  Lines       14540    14540              
  Branches      772      772              
==========================================
+ Hits        12475    12479       +4     
+ Misses       2065     2061       -4
Impacted Files Coverage Δ
...crosoft/azure/synapse/ml/io/http/HTTPClients.scala 75.00% <0.00%> (-2.95%) ⬇️
...t/azure/synapse/ml/cognitive/SpeechToTextSDK.scala 93.33% <0.00%> (+1.96%) ⬆️
.../azure/synapse/ml/core/utils/JarLoadingUtils.scala 62.06% <0.00%> (+3.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@k-rush
Copy link
Contributor Author

k-rush commented Oct 19, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@k-rush k-rush changed the title [WIP] Synapse extension E2E tests [WIP] Add more E2E test to pipeline Oct 19, 2022
@k-rush k-rush changed the title [WIP] Add more E2E test to pipeline test: [WIP] Add more E2E test to pipeline Oct 19, 2022
@k-rush
Copy link
Contributor Author

k-rush commented Oct 19, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@k-rush
Copy link
Contributor Author

k-rush commented Oct 19, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@k-rush
Copy link
Contributor Author

k-rush commented Oct 19, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@k-rush
Copy link
Contributor Author

k-rush commented Oct 19, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

niehaus59
niehaus59 previously approved these changes Oct 28, 2022
View reviewed changes
@k-rush k-rush changed the title test: [WIP] Add more E2E test to pipeline test: Add more E2E test to pipeline Oct 28, 2022
@k-rush k-rush marked this pull request as ready for review October 28, 2022 23:41
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@k-rush
Copy link
Contributor Author

k-rush commented Nov 14, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@k-rush k-rush enabled auto-merge (squash) November 14, 2022 23:46
@k-rush k-rush force-pushed the kyrush/synapseextensione2etests branch from a66e4cd to 81fca9a Compare November 15, 2022 20:07
@k-rush
Copy link
Contributor Author

k-rush commented Nov 15, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@k-rush
Copy link
Contributor Author

k-rush commented Nov 15, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@k-rush
Copy link
Contributor Author

k-rush commented Nov 15, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit 59b900c into microsoft:master Nov 16, 2022
k-rush added a commit that referenced this pull request Nov 17, 2022
@k-rush
Revert "test: Add SynapseInternal E2E tests (#1683)"
fa4b1ba 
This reverts commit 59b900c.
@k-rush k-rush mentioned this pull request Nov 17, 2022
Merged
mhamilton723 pushed a commit that referenced this pull request Nov 17, 2022
@k-rush
Revert "test: Add SynapseInternal E2E tests (#1683)" (#1721)
aecf9c0 
This reverts commit 59b900c.
@k-rush k-rush deleted the kyrush/synapseextensione2etests branch November 17, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niehaus59 niehaus59 niehaus59 left review comments

@mhamilton723 mhamilton723 mhamilton723 approved these changes

@svotaw svotaw Awaiting requested review from svotaw svotaw is a code owner

@eisber eisber Awaiting requested review from eisber eisber is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@k-rush @codecov-commenter @mhamilton723 @niehaus59