docs: Added more up-to-date ONNX docs #1781

svotaw · 2023-01-03T20:57:08Z

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Added docs for new ONNX content.

How is this patch tested?

I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

No. You can skip this section.
Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

No. You can skip this section.
Yes. Make sure you have added samples following below steps.

Find the corresponding markdown file for your new feature in website/docs/documentation folder.
Make sure you choose the correct class estimators/transformers and namespace.
Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
Make sure the DocTable points to correct API link.
Navigate to website folder, and run yarn run start to make sure the website renders correctly.
Don't forget to add  before each python code blocks to enable auto-tests for python samples.
Make sure the WebsiteSamplesTests job pass in the pipeline.

acrolinxatmsft1 · 2023-01-03T20:57:15Z

Acrolinx Scorecards

A minimum Acrolinx score of 80 is required.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article	Acrolinx score	Word and Phrases Score	Correctness Score	Scorecard	Processed
website/docs/features/onnx/about.md	76	100	66	link	✅

More information about Acrolinx

github-actions · 2023-01-03T20:57:24Z

Hey @svotaw 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

fix: Fix LightGBM crashes with empty partitions
feat: Make HTTP on Spark back-offs configurable
docs: Update Spark Serving usage
build: Add codecov support
perf: improve LightGBM memory usage
refactor: make python code generation rely on classes
style: Remove nulls from CNTKModel
test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

svotaw · 2023-01-04T20:37:58Z

/azp run

azure-pipelines · 2023-01-04T20:38:10Z

Azure Pipelines successfully started running 1 pipeline(s).

codecov-commenter · 2023-01-04T20:47:52Z

Codecov Report

Merging #1781 (709ee25) into master (dd1563f) will decrease coverage by 9.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1781      +/-   ##
==========================================
- Coverage   86.08%   76.75%   -9.33%     
==========================================
  Files         278      278              
  Lines       14722    14722              
  Branches      767      767              
==========================================
- Hits        12673    11300    -1373     
- Misses       2049     3422    +1373

Impacted Files	Coverage Δ
...m/src/main/scala/com/microsoft/lightgbm/SWIG.scala	`0.00% <0.00%> (-100.00%)`	⬇️
...pse/ml/lightgbm/params/ClassifierTrainParams.scala	`0.00% <0.00%> (-100.00%)`	⬇️
...e/synapse/ml/lightgbm/StreamingPartitionTask.scala	`0.00% <0.00%> (-97.11%)`	⬇️
...zure/synapse/ml/lightgbm/dataset/SampledData.scala	`0.00% <0.00%> (-90.00%)`	⬇️
...ure/synapse/ml/cognitive/speech/AudioStreams.scala	`0.00% <0.00%> (-87.88%)`	⬇️
...azure/synapse/ml/lightgbm/LightGBMClassifier.scala	`10.75% <0.00%> (-80.65%)`	⬇️
...apse/ml/cognitive/form/FormRecognizerSchemas.scala	`7.69% <0.00%> (-76.93%)`	⬇️
...ynapse/ml/cognitive/form/FormOntologyLearner.scala	`14.28% <0.00%> (-75.52%)`	⬇️
...azure/synapse/ml/featurize/text/PageSplitter.scala	`25.58% <0.00%> (-74.42%)`	⬇️
.../synapse/ml/cognitive/speech/SpeechToTextSDK.scala	`18.03% <0.00%> (-73.34%)`	⬇️
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

website/docs/features/onnx/about.md

mhamilton723

Love it! Just a few minor comments and nits

acrolinxatmsft1 · 2023-01-05T20:08:40Z

Acrolinx Scorecards

A minimum Acrolinx score of 80 is required.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article	Acrolinx score	Word and Phrases Score	Correctness Score	Scorecard	Processed
website/docs/features/onnx/about.md	87	100	73	link	✅

More information about Acrolinx

acrolinxatmsft1 · 2023-01-05T20:08:54Z

Acrolinx Scorecards

A minimum Acrolinx score of 80 is required.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article	Acrolinx score	Word and Phrases Score	Correctness Score	Scorecard	Processed
website/docs/features/onnx/about.md	87	100	73	link	✅

More information about Acrolinx

svotaw · 2023-01-05T20:09:01Z

/azp run

azure-pipelines · 2023-01-05T20:09:13Z

Azure Pipelines successfully started running 1 pipeline(s).

website/docs/features/onnx/about.md

mhamilton723

It still looks like theres a few good suggestions in acrolinx

https://microsoft-ce-csi.acrolinx.cloud/api/v1/checking/scorecards/b36dc9cd-07a6-4e59-a45e-1b79f16f682f

Would you be able do the easy ones (The nouns after this, contractions, a/an, and no e.g) ? (No need to correct Netron)

Wuld

acrolinxatmsft1 · 2023-01-09T17:52:15Z

Acrolinx Scorecards

A minimum Acrolinx score of 80 is required.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article	Acrolinx score	Word and Phrases Score	Correctness Score	Scorecard	Processed
website/docs/features/onnx/about.md	96	100	80	link	✅

More information about Acrolinx

acrolinxatmsft1 · 2023-01-09T17:52:37Z

Acrolinx Scorecards

A minimum Acrolinx score of 80 is required.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article	Acrolinx score	Word and Phrases Score	Correctness Score	Scorecard	Processed
website/docs/features/onnx/about.md	96	100	80	link	✅

More information about Acrolinx

svotaw · 2023-01-09T17:53:37Z

/azp run

azure-pipelines · 2023-01-09T17:53:47Z

Azure Pipelines successfully started running 1 pipeline(s).

svotaw · 2023-01-10T18:01:32Z

/azp run

acrolinxatmsft1 · 2023-01-10T18:01:32Z

Acrolinx Scorecards

A minimum Acrolinx score of 80 is required.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article	Acrolinx score	Word and Phrases Score	Correctness Score	Scorecard	Processed
website/docs/features/onnx/about.md	96	100	80	link	✅

More information about Acrolinx

azure-pipelines · 2023-01-10T18:01:45Z

Azure Pipelines successfully started running 1 pipeline(s).

acrolinxatmsft1 · 2023-01-11T22:06:48Z

Acrolinx Scorecards

A minimum Acrolinx score of 80 is required.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article	Acrolinx score	Word and Phrases Score	Correctness Score	Scorecard	Processed
website/docs/features/onnx/about.md	96	100	80	link	✅

More information about Acrolinx

Added more up-to-date ONNX docs

cb6bf9d

svotaw requested a review from serena-ruan as a code owner January 3, 2023 20:57

svotaw requested a review from mhamilton723 January 3, 2023 20:57

mhamilton723 reviewed Jan 4, 2023

View reviewed changes

website/docs/features/onnx/about.md Outdated Show resolved Hide resolved

mhamilton723 reviewed Jan 4, 2023

View reviewed changes

website/docs/features/onnx/about.md Outdated Show resolved Hide resolved

mhamilton723 reviewed Jan 4, 2023

View reviewed changes

website/docs/features/onnx/about.md Show resolved Hide resolved

mhamilton723 reviewed Jan 4, 2023

View reviewed changes

website/docs/features/onnx/about.md Outdated Show resolved Hide resolved

mhamilton723 reviewed Jan 4, 2023

View reviewed changes

website/docs/features/onnx/about.md Outdated Show resolved Hide resolved

mhamilton723 requested changes Jan 4, 2023

View reviewed changes

responded to comments and acrolinx

aae6d2d

Merge branch 'master' into onnxdocs

88444ca

mhamilton723 reviewed Jan 9, 2023

View reviewed changes

website/docs/features/onnx/about.md Outdated Show resolved Hide resolved

mhamilton723 requested changes Jan 9, 2023

View reviewed changes

more comments and acrolinx

feb316a

Merge branch 'master' into onnxdocs

7209ad0

Merge branch 'master' into onnxdocs

709ee25

svotaw requested a review from mhamilton723 January 10, 2023 18:04

mhamilton723 approved these changes Jan 11, 2023

View reviewed changes

Merge branch 'master' into onnxdocs

23f45cc

mhamilton723 merged commit 974e36a into microsoft:master Jan 11, 2023

svotaw deleted the onnxdocs branch January 12, 2023 16:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Added more up-to-date ONNX docs #1781

docs: Added more up-to-date ONNX docs #1781

svotaw commented Jan 3, 2023

acrolinxatmsft1 commented Jan 3, 2023

github-actions bot commented Jan 3, 2023

svotaw commented Jan 4, 2023

azure-pipelines bot commented Jan 4, 2023

codecov-commenter commented Jan 4, 2023 •

edited

mhamilton723 left a comment

acrolinxatmsft1 commented Jan 5, 2023

acrolinxatmsft1 commented Jan 5, 2023

svotaw commented Jan 5, 2023

azure-pipelines bot commented Jan 5, 2023

mhamilton723 left a comment

acrolinxatmsft1 commented Jan 9, 2023

acrolinxatmsft1 commented Jan 9, 2023

svotaw commented Jan 9, 2023

azure-pipelines bot commented Jan 9, 2023

svotaw commented Jan 10, 2023

acrolinxatmsft1 commented Jan 10, 2023

azure-pipelines bot commented Jan 10, 2023

acrolinxatmsft1 commented Jan 11, 2023

docs: Added more up-to-date ONNX docs #1781

docs: Added more up-to-date ONNX docs #1781

Conversation

svotaw commented Jan 3, 2023

Related Issues/PRs

What changes are proposed in this pull request?

How is this patch tested?

Does this PR change any dependencies?

Does this PR add a new feature? If so, have you added samples on website?

acrolinxatmsft1 commented Jan 3, 2023

Acrolinx Scorecards

github-actions bot commented Jan 3, 2023

svotaw commented Jan 4, 2023

azure-pipelines bot commented Jan 4, 2023

codecov-commenter commented Jan 4, 2023 • edited

Codecov Report

mhamilton723 left a comment

Choose a reason for hiding this comment

acrolinxatmsft1 commented Jan 5, 2023

Acrolinx Scorecards

acrolinxatmsft1 commented Jan 5, 2023

Acrolinx Scorecards

svotaw commented Jan 5, 2023

azure-pipelines bot commented Jan 5, 2023

mhamilton723 left a comment

Choose a reason for hiding this comment

acrolinxatmsft1 commented Jan 9, 2023

Acrolinx Scorecards

acrolinxatmsft1 commented Jan 9, 2023

Acrolinx Scorecards

svotaw commented Jan 9, 2023

azure-pipelines bot commented Jan 9, 2023

svotaw commented Jan 10, 2023

acrolinxatmsft1 commented Jan 10, 2023

Acrolinx Scorecards

azure-pipelines bot commented Jan 10, 2023

acrolinxatmsft1 commented Jan 11, 2023

Acrolinx Scorecards

codecov-commenter commented Jan 4, 2023 •

edited