-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add metric parameter to lightgbm learners #672
feat: add metric parameter to lightgbm learners #672
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #672 +/- ##
==========================================
- Coverage 79.9% 79.72% -0.18%
==========================================
Files 225 225
Lines 9033 9037 +4
Branches 483 484 +1
==========================================
- Hits 7218 7205 -13
- Misses 1815 1832 +17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing
5582772
to
2c9c7cb
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
2c9c7cb
to
353b9bc
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
353b9bc
to
792fc34
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@imatiach-msft |
@candalfigomoro yes it should, with comma separated metrics. For early stopping we also use all metrics specified (note early stopping is not provided in native api so R/python and our spark implementation all have their own implementation): |
@imatiach-msft |
@nishant-ai I think it should support all lightgbm metrics as specified here: |
Yes, I meant the eval_at parameter only. I had a look at the code and the eval_at parameter used for @n metrics didn't seem to be exposed, just wanted to confirm that. |
Thanks @imatiach-msft ! |
resolves #631 and #628