-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding a feature for positive and negative bagging fraction params. #754
feat: Adding a feature for positive and negative bagging fraction params. #754
Conversation
Keunhyun Oh <keunhyun.oh@ahnlab.com>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #754 +/- ##
=========================================
+ Coverage 80.05% 80.16% +0.1%
=========================================
Files 230 230
Lines 9197 9209 +12
Branches 504 505 +1
=========================================
+ Hits 7363 7382 +19
+ Misses 1834 1827 -7
Continue to review full report at Codecov.
|
src/main/scala/com/microsoft/ml/spark/lightgbm/LightGBMParams.scala
Outdated
Show resolved
Hide resolved
fix pos => neg in line 100
…s added for fraction parameters. Keunhyun Oh <keunhyun.oh@ahnlab.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@mhamilton723 seems there is some issue contacting cluster in the E2E tests, is there a known issue currently? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@mhamilton723 has the cluster issue been resolved? It seems the most recent builds are passing. Hopefully this should pass. |
@mhamilton723 can this PR be merged? thanks! |
Congrats on merging your first pull request, we appreciate your support! 🎉🎉🎉 |
Adding a feature for positive and negative bagging fraction params.
Keunhyun Oh keunhyun.oh@ahnlab.com