Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding a feature for positive and negative bagging fraction params. #754

Merged
merged 4 commits into from
Dec 9, 2019
Merged

feat: Adding a feature for positive and negative bagging fraction params. #754

merged 4 commits into from
Dec 9, 2019

Conversation

ocworld
Copy link
Contributor

@ocworld ocworld commented Dec 5, 2019

Adding a feature for positive and negative bagging fraction params.

Keunhyun Oh keunhyun.oh@ahnlab.com

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #754 into master will increase coverage by 0.1%.
The diff coverage is 88%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #754     +/-   ##
=========================================
+ Coverage   80.05%   80.16%   +0.1%     
=========================================
  Files         230      230             
  Lines        9197     9209     +12     
  Branches      504      505      +1     
=========================================
+ Hits         7363     7382     +19     
+ Misses       1834     1827      -7
Impacted Files Coverage Δ
...m/microsoft/ml/spark/lightgbm/LightGBMRanker.scala 60.86% <100%> (+0.86%) ⬆️
...icrosoft/ml/spark/lightgbm/LightGBMRegressor.scala 67.5% <100%> (+0.83%) ⬆️
.../com/microsoft/ml/spark/lightgbm/TrainParams.scala 100% <100%> (ø) ⬆️
...crosoft/ml/spark/lightgbm/LightGBMClassifier.scala 87.34% <100%> (+0.16%) ⬆️
...m/microsoft/ml/spark/lightgbm/LightGBMParams.scala 86.61% <81.25%> (-0.7%) ⬇️
.../apache/spark/ml/feature/FastVectorAssembler.scala 68.49% <0%> (+1.36%) ⬆️
...m/microsoft/ml/spark/core/schema/SparkSchema.scala 83.33% <0%> (+2.08%) ⬆️
...a/com/microsoft/ml/spark/io/http/HTTPClients.scala 60.71% <0%> (+3.57%) ⬆️
.../microsoft/ml/spark/core/schema/Categoricals.scala 86.45% <0%> (+4.16%) ⬆️
...osoft/ml/spark/core/schema/DatasetExtensions.scala 100% <0%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 087f290...b6abd6a. Read the comment docs.

Keunhyun Oh added 2 commits December 6, 2019 13:18
fix pos => neg in line 100
…s added for fraction parameters.

Keunhyun Oh <keunhyun.oh@ahnlab.com>
Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imatiach-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor

@mhamilton723 seems there is some issue contacting cluster in the E2E tests, is there a known issue currently?

@imatiach-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor

@mhamilton723 has the cluster issue been resolved? It seems the most recent builds are passing. Hopefully this should pass.

@imatiach-msft
Copy link
Contributor

@mhamilton723 can this PR be merged? thanks!

@mhamilton723 mhamilton723 merged commit 43b4e63 into microsoft:master Dec 9, 2019
@welcome
Copy link

welcome bot commented Dec 9, 2019

Congrats on merging your first pull request, we appreciate your support! 🎉🎉🎉

@ocworld ocworld deleted the pos-neg-bagging-fraction branch December 10, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants