fix: refactor python wrappers to use common class #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
changed the title
|
tagging @chris-smith-zocdoc |
chris-smith-zocdoc
suggested changes
Dec 12, 2019
imatiach-msft
force-pushed
the
ilmat/py-set-col
branch
from
3739768
to
1f967ee
Compare
imatiach-msft
force-pushed
the
ilmat/py-set-col
branch
from
1f967ee
to
13a953b
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
imatiach-msft
changed the title
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
==========================================
- Coverage 84.12% 84.08% -0.05%
==========================================
Files 202 202
Lines 9386 9386
Branches 557 557
==========================================
- Hits 7896 7892 -4
- Misses 1490 1494 +4
Continue to review full report at Codecov.
|
mhamilton723
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add set methods to lightgbm models in pyspark APIs
resolves issue #721
Update: the original issue was fixed with new codegen, this PR now updates the python wrappers to use a common class