added support for readable model, invert hash and re-using a previous… #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly trained VW Spark model
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #821 +/- ##
==========================================
- Coverage 85.32% 83.60% -1.72%
==========================================
Files 186 186
Lines 8597 8560 -37
Branches 507 492 -15
==========================================
- Hits 7335 7157 -178
- Misses 1262 1403 +141
Continue to review full report at Codecov.
|
imatiach-msft
previously approved these changes
Mar 10, 2020
src/main/scala/com/microsoft/ml/spark/vw/VowpalWabbitBase.scala
Outdated
Show resolved
Hide resolved
mhamilton723
requested changes
Mar 10, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ocworld
pushed a commit
to AhnLab-OSS/mmlspark
that referenced
this pull request
Mar 24, 2020
…revious… (microsoft#821) * added support for readable model, invert hash and re-using a previously trained VW Spark model *
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ly trained VW Spark model
close #816
Please note I'm not sure how helpful invert hash is as the original input isn't passed along. The estimator only sees the Sparse/Dense Spark ML vector.