Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add delegate to monitor training #847

Merged
merged 2 commits into from
Mar 31, 2020
Merged

feat: add delegate to monitor training #847

merged 2 commits into from
Mar 31, 2020

Conversation

ocworld
Copy link
Contributor

@ocworld ocworld commented Mar 31, 2020

It is needed to monitor and hook in each training iteration.

It's because how well training my model and how much better metrics such as auc in each boost round.

contacts: keunhyun.oh@ahnlab.com

@ocworld
Copy link
Contributor Author

ocworld commented Mar 31, 2020

@AhnLab-OSS

@imatiach-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #847 into master will decrease coverage by 1.20%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #847      +/-   ##
==========================================
- Coverage   85.17%   83.97%   -1.21%     
==========================================
  Files         186      186              
  Lines        8588     8603      +15     
  Branches      512      508       -4     
==========================================
- Hits         7315     7224      -91     
- Misses       1273     1379     +106     
Impacted Files Coverage Δ
.../com/microsoft/ml/spark/lightgbm/TrainParams.scala 100.00% <ø> (ø)
...m/microsoft/ml/spark/lightgbm/LightGBMParams.scala 86.18% <66.66%> (-0.33%) ⬇️
...a/com/microsoft/ml/spark/lightgbm/TrainUtils.scala 86.41% <68.75%> (-1.03%) ⬇️
...crosoft/ml/spark/lightgbm/LightGBMClassifier.scala 88.63% <100.00%> (ø)
...m/microsoft/ml/spark/lightgbm/LightGBMRanker.scala 60.37% <100.00%> (ø)
...icrosoft/ml/spark/lightgbm/LightGBMRegressor.scala 68.29% <100.00%> (ø)
...cala/com/microsoft/ml/spark/io/binary/Binary.scala 0.00% <0.00%> (-100.00%) ⬇️
...icrosoft/ml/spark/io/binary/BinaryFileReader.scala 0.00% <0.00%> (-73.92%) ⬇️
.../microsoft/ml/spark/core/env/StreamUtilities.scala 25.92% <0.00%> (-59.26%) ⬇️
...spark/ml/source/image/PatchedImageFileFormat.scala 48.14% <0.00%> (-40.75%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c695d7a...1af00bb. Read the comment docs.

imatiach-msft
imatiach-msft previously approved these changes Mar 31, 2020
Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -325,4 +325,11 @@ trait LightGBMParams extends Wrappable with DefaultParamsWritable with HasWeight

def getMinDataInLeaf: Int = $(minDataInLeaf)
def setMinDataInLeaf(value: Int): this.type = set(minDataInLeaf, value)

var delegate: Option[LightGBMDelegate] = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably figure out how to make this inherit from param and expose in python layer, but maybe not for this PR

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft imatiach-msft merged commit be366c5 into microsoft:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants