Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error message for invalid slot names #897

Merged

Conversation

imatiach-msft
Copy link
Contributor

fix: improve error message for invalid slot names

resolves
#887

related LightGBM code for special characters:
https://github.com/microsoft/LightGBM/blob/master/include/LightGBM/utils/common.h#L965

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #897 into master will increase coverage by 1.84%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #897      +/-   ##
==========================================
+ Coverage   83.31%   85.16%   +1.84%     
==========================================
  Files         189      189              
  Lines        8769     8783      +14     
  Branches      558      548      -10     
==========================================
+ Hits         7306     7480     +174     
+ Misses       1463     1303     -160     
Impacted Files Coverage Δ
...com/microsoft/ml/spark/lightgbm/LightGBMBase.scala 92.50% <100.00%> (+1.59%) ⬆️
...osoft/ml/spark/io/http/PartitionConsolidator.scala 68.88% <0.00%> (-26.67%) ⬇️
.../microsoft/ml/spark/vw/VowpalWabbitRegressor.scala 70.00% <0.00%> (+10.00%) ⬆️
...a/com/microsoft/ml/spark/vw/VowpalWabbitBase.scala 89.04% <0.00%> (+15.06%) ⬆️
...a/com/microsoft/ml/spark/vw/HasSumcollisions.scala 100.00% <0.00%> (+25.00%) ⬆️
.../scala/com/microsoft/ml/spark/vw/VectorUtils.scala 96.42% <0.00%> (+28.57%) ⬆️
...n/scala/com/microsoft/ml/spark/vw/HasNumBits.scala 85.71% <0.00%> (+28.57%) ⬆️
...microsoft/ml/spark/vw/VowpalWabbitFeaturizer.scala 87.50% <0.00%> (+35.22%) ⬆️
...oft/ml/spark/vw/VowpalWabbitMurmurWithPrefix.scala 70.73% <0.00%> (+36.58%) ⬆️
...microsoft/ml/spark/vw/VowpalWabbitClassifier.scala 90.90% <0.00%> (+39.39%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95c1f8a...9849d1a. Read the comment docs.

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants