Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Recommender Patch for Spark 3 Update #982

Merged
merged 1 commit into from Feb 1, 2021

Conversation

dciborow
Copy link
Contributor

Fixing some bugs that popped up with Spark 3.

@dciborow dciborow force-pushed the dciborow/spark3-patch branch 2 times, most recently from d68443c to 3b18519 Compare February 1, 2021 02:02
@dciborow dciborow changed the title Recommender Patch for Spark 3 Update fix: Recommender Patch for Spark 3 Update Feb 1, 2021
@dciborow dciborow force-pushed the dciborow/spark3-patch branch 2 times, most recently from f5ee7ef to cb31b30 Compare February 1, 2021 02:08
@dciborow
Copy link
Contributor Author

dciborow commented Feb 1, 2021

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 982 in repo Azure/mmlspark

@dciborow
Copy link
Contributor Author

dciborow commented Feb 1, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #982 (f492c12) into master (6218a5b) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
- Coverage   84.90%   84.83%   -0.08%     
==========================================
  Files         195      195              
  Lines        9071     9071              
  Branches      552      552              
==========================================
- Hits         7702     7695       -7     
- Misses       1369     1376       +7     
Impacted Files Coverage Δ
...a/com/microsoft/ml/spark/io/http/HTTPClients.scala 57.14% <0.00%> (-16.08%) ⬇️
...k/recommendation/RankingTrainValidationSplit.scala 76.41% <0.00%> (+0.94%) ⬆️
...osoft/ml/spark/io/http/PartitionConsolidator.scala 95.55% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13ce0c9...f492c12. Read the comment docs.

@dciborow
Copy link
Contributor Author

dciborow commented Feb 1, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit f14623e into microsoft:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants