Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not provide client id in SecretProviderClass #1512

Open
herquan-docusign opened this issue Apr 3, 2024 · 0 comments
Open

Do not provide client id in SecretProviderClass #1512

herquan-docusign opened this issue Apr 3, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@herquan-docusign
Copy link

Describe the solution you'd like

Today the client id in both SecretProviderClass and ServiceAccount should be same and such information is duplicated. We can add a flag to let SecretProviderClass always use the client id provided by the service account of the pod rather than us providing it as a parameter.

Anything else you would like to add:

There is a pull request pending for review that could be a solution

Environment:

  • Secrets Store CSI Driver version: (use the image tag):
  • Azure Key Vault provider version: (use the image tag): v1.5.1
  • Kubernetes version: (use kubectl version): 1.28.5
  • Cluster type: (e.g. AKS, aks-engine, etc): AKS
@herquan-docusign herquan-docusign added the enhancement New feature or request label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant