Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to configure the default cloud environment #1541

Closed
aramase opened this issue Apr 22, 2024 · 0 comments · Fixed by #1555
Closed

Add a flag to configure the default cloud environment #1541

aramase opened this issue Apr 22, 2024 · 0 comments · Fixed by #1555
Assignees
Labels
enhancement New feature or request

Comments

@aramase
Copy link
Member

aramase commented Apr 22, 2024

The current logic uses AzurePublicCloud as default option when no cloud name is provided.

if cloudName == "" {
env = azure.PublicCloud
} else {
env, err = azure.EnvironmentFromName(cloudName)
}

Add a flag in the provider to configure default cloud to use if cloudName is not provided in SecretProviderClass.
This will be useful in custom cloud envs for defining AzureStackCloud as default + setting AZURE_ENVIRONMENT_FILEPATH one-time at the provider level instead of every SecretProviderClass.

@aramase aramase added the enhancement New feature or request label Apr 22, 2024
@aramase aramase self-assigned this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant