Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved provision application test to use the validate command method i… #79

Merged
merged 2 commits into from
Apr 5, 2018
Merged

Moved provision application test to use the validate command method i… #79

merged 2 commits into from
Apr 5, 2018

Conversation

Christina-Kang
Copy link
Contributor

@Christina-Kang Christina-Kang commented Apr 4, 2018 •
edited

…nstead of a custom one

Changes include:

  • Change how validation is done for provision application command to leverage non-live cluster validation method.

Verifed:

  • Build and test CI passes
  • History and readme updated to reflect changes
  • Package version updated according to semantic versioning rules
  • Tests modified or added, when applicable

@coveralls
Copy link

coveralls commented Apr 4, 2018 •
edited

Coverage Status

Coverage increased (+2.2%) to 75.321% when pulling 69c5eff on Christina-Kang:provision-app-test-non-live-cluster into 414efc7 on Azure:master.

@Christina-Kang Christina-Kang merged commit a584773 into microsoft:master Apr 5, 2018
@Christina-Kang Christina-Kang deleted the provision-app-test-non-live-cluster branch November 1, 2018 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samedder samedder Awaiting requested review from samedder samedder is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Christina-Kang @coveralls