New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for passing json values to arguments as .txt files #84
Add support for passing json values to arguments as .txt files #84
Conversation
@samedder Can you review this? Thanks :) |
Is this something that Knack cannot support? |
@samedder I don't see support for this in their code or docs. |
Rather than us writing custom logic for this, we should contribute to Knack or request them to support this. I don't think this is a feature that should only be added to our CLI. |
I've submitted an issue on their github, but that will take quite a bit of time I suspect. I do not have the time to add to their repo any time soon, and our commands are getting more unmanageable as we add more things for which we can't avoid json easily. We can then remove this when the knack team adds in that feature. |
If you've written all the code already for our CLI how much more effort would it be to migrate it back out to knack? |
@samedder I would need to go through all their code and determine what is the best way of adding this without impacting existing items. Probably as a pre-defined built in type, then understand their testing framework which I have not looked at, then update docs, etc. I would need to discuss with their team if that's how they want it to be implemented. It's a non-trivial amount of work to port this. I can add a tracking item and get to it when I have time, but I doubt it will be this month. |
@Christina-Kang two things: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge, but like I said be careful about adding features like this
Link PR number to entry in readme file
…soft#84) Add support for inputting JSON values by providing a path to a file rather than only by provided a JSON string. To do so, set argument value to the relative or absolute path of the text file prefixed by "@".
Changes include:
Verifed: